llvm: expose target ABI name option - #2
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for specifying the target ABI name (ABIName) when creating a target machine, updating both the Go API and the underlying C++ bindings to handle this across different LLVM versions (including LLVM 18+ and legacy versions). Feedback suggests initializing the JIT boolean variable to false in TargetBindings.cpp to prevent issues with uninitialized variables, and using t.Skipf instead of t.Fatal in the RISC-V test to gracefully handle environments where the RISC-V backend is not installed.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
5328d84 to
4f46e28
Compare
Summary
Motivation
LLGo target resolution carries an explicit target ABI. Applying it at target-machine construction avoids guessing LLVM backend defaults and is required for correct calling conventions and object metadata.
Validation