Skip to content

[Based on #120] cmd: add LLDB views for interfaces and function values - #99

Open
cpunion wants to merge 1 commit into
codex/debugger-abi-schema-2164-20260802from
codex/lldb-interface-funcvals-20260801
Open

[Based on #120] cmd: add LLDB views for interfaces and function values#99
cpunion wants to merge 1 commit into
codex/debugger-abi-schema-2164-20260802from
codex/lldb-interface-funcvals-20260801

Conversation

@cpunion

@cpunion cpunion commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • load interface and function-value layouts from the common debugger ABI schema introduced by [Based on #114] debug: define the common debugger ABI #120
  • show nil and dynamic concrete types for empty and non-empty interfaces
  • resolve ordinary and named function values to symbols, and identify closures and bound methods
  • execute every covered value in the fixture before inspecting it

Tracks xgo-dev#2154 and xgo-dev#2164. Based on #120.

Tests

  • macOS arm64, Apple LLDB 1703: 243/243 integration assertions
  • Linux amd64, LLVM LLDB 19.1.7: 243/243 integration assertions
  • macOS arm64 and Linux amd64: go test ./cmd/...
  • macOS arm64 and Linux amd64: cmd/internal/lldb coverage 87.5%
  • full PR CI: 39 successful jobs, one expected skipped release job
  • Python syntax checks and git diff --check

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

LLGo baseline benchmarks

48ce57e35de3 | workflow run | long-term charts

Program measurements

Platform Workload File size vs main Build vs main Run vs main
Linux cprintf 18544 B +0.0% 344.346 ms -16.5% (better) 1.362 ms -12.3% (better)
Linux fmtprintf 2217608 B +0.2% (worse) 3.211 s -16.7% (better) 2.713 ms -17.5% (better)
Linux println 71504 B -1.6% (better) 354.966 ms -11.3% (better) 1.695 ms +1.3% (worse)
macOS cprintf 84672 B +0.0% 307.763 ms -25.7% (better) 2.443 ms -31.9% (better)
macOS fmtprintf 2361520 B +0.7% (worse) 3.789 s -3.8% (better) 21.814 ms -6.7% (better)
macOS println 125712 B -1.0% (better) 310.929 ms -25.0% (better) 3.494 ms -51.9% (better)
Core language and compiler benchmarks
Platform Benchmark ns/op vs main
Linux BenchmarkLookupPCRandom 12.270 ns/op -9.0% (better)
Linux BenchmarkMergeCompilerFlags 148.600 ns/op -3.8% (better)
Linux BenchmarkMergeLinkerFlags 95.060 ns/op -6.2% (better)
Linux BenchmarkChannelBuffered 36.320 ns/op +4.5% (worse)
Linux BenchmarkChannelHandoff 25913 ns/op -19.1% (better)
Linux BenchmarkDefer 42.530 ns/op -24.5% (better)
Linux BenchmarkDirectCall 1.758 ns/op +12.5% (worse)
Linux BenchmarkGlobalRead 1.759 ns/op +12.8% (worse)
Linux BenchmarkGlobalWrite 2.806 ns/op +12.5% (worse)
Linux BenchmarkGoroutine 36752 ns/op -51.4% (better)
Linux BenchmarkInterfaceCall 8.792 ns/op +12.8% (worse)
Linux BenchmarkRuntimeGetG 1.759 ns/op -66.9% (better)
macOS BenchmarkLookupPCRandom 13.030 ns/op +4.7% (worse)
macOS BenchmarkMergeCompilerFlags 143.700 ns/op +15.4% (worse)
macOS BenchmarkMergeLinkerFlags 93.370 ns/op +34.6% (worse)
macOS BenchmarkChannelBuffered 28.740 ns/op +3.6% (worse)
macOS BenchmarkChannelHandoff 8389 ns/op +19.7% (worse)
macOS BenchmarkDefer 52.070 ns/op +39.1% (worse)
macOS BenchmarkDirectCall 1.235 ns/op -15.0% (better)
macOS BenchmarkGlobalRead 1.243 ns/op +2.6% (worse)
macOS BenchmarkGlobalWrite 1.300 ns/op -12.6% (better)
macOS BenchmarkGoroutine 38720 ns/op +22.3% (worse)
macOS BenchmarkInterfaceCall 5.318 ns/op -1.5% (better)
macOS BenchmarkRuntimeGetG 2.305 ns/op -10.6% (better)

Compared only with the latest matching platform in the main series.

Warning

  • Persistent publishing is unavailable because no data token is configured.

@cpunion
cpunion force-pushed the codex/lldb-interface-funcvals-20260801 branch from b0a580d to 6ea6b5b Compare August 1, 2026 07:57
@cpunion cpunion changed the title [Based on #98] cmd: add LLDB views for interfaces and function values cmd: add LLDB views for interfaces and function values Aug 1, 2026
@cpunion
cpunion changed the base branch from coro/sync-main-20260801 to main August 1, 2026 07:58
@cpunion
cpunion force-pushed the codex/lldb-interface-funcvals-20260801 branch from 6ea6b5b to 50ebac0 Compare August 1, 2026 20:50
@cpunion cpunion changed the title cmd: add LLDB views for interfaces and function values [Based on #120] cmd: add LLDB views for interfaces and function values Aug 1, 2026
@cpunion
cpunion changed the base branch from main to codex/debugger-abi-schema-2164-20260802 August 1, 2026 20:50
@cpunion
cpunion force-pushed the codex/debugger-abi-schema-2164-20260802 branch from d6ab27a to 2ba269c Compare August 2, 2026 07:05
@cpunion
cpunion force-pushed the codex/lldb-interface-funcvals-20260801 branch from 50ebac0 to 48ce57e Compare August 2, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant