[Based on #138] debug: integrate DWARF-safe defaults - #139
Open
cpunion wants to merge 25 commits into
Open
Conversation
ssa.GlobalDebug inserts metadata-only DebugRefs between a return load and its Return. Treating those references as executable users prevents the existing gc-compatible order repair from running, while moving only the load would invalidate SSA order. Move each related DebugRef with the load. This preserves LLGo compatibility for the behavior discussed in golang/go#77938; it does not make the unspecified Go expression order normative.
The single-case select repair moves receive-assignment LHS dependencies after the receive, as required by select evaluation order. Under ssa.GlobalDebug, metadata-only DebugRefs looked like pre-receive users and blocked that repair. Include those DebugRefs in the same stable move set so default and GlobalDebug SSA retain identical runtime ordering.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
LLGo baseline benchmarks
Program measurements
Core language and compiler benchmarks
Compared only with the latest matching platform in the main series. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates the source-debugging dependency chain required by xgo-dev#2164 on top of #138 without pulling scheduler implementation into the proposal.
Upstream review units remain xgo-dev#2183, xgo-dev#2184, xgo-dev#2143, xgo-dev#2148, xgo-dev#2157, xgo-dev#2142, and xgo-dev#2202. This PR is the latest-main combination and acceptance layer.
Validation:
Binaryen's released Asyncify still exhibits WebAssembly/binaryen#6406 on this layer's final browser artifact. The stacked #140 closes that final-artifact gate with the repair proposed upstream as WebAssembly/binaryen#8964 and keeps strict
llvm-dwarfdump --verifychecks enabled; this PR does not weaken validation or change runtime semantics.