debug: allow supported targets to retain DWARF - #108
Open
cpunion wants to merge 1 commit into
Open
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
LLGo baseline benchmarks
Program measurements
Core language and compiler benchmarks
Compared only with the latest matching platform in the main series. Warning
|
cpunion
force-pushed
the
codex/debug-artifact-policy-2164-20260801
branch
2 times, most recently
from
August 2, 2026 07:05
2d13fd3 to
5b3dbe4
Compare
cpunion
force-pushed
the
codex/debug-artifact-policy-2164-20260801
branch
from
August 3, 2026 00:44
5b3dbe4 to
c9c9171
Compare
Owner
Author
|
Rebased the root commit onto current xgo-dev/main (4e1aa4f); new head is c9c9171. Root-level targeted tests pass. Staged upstream as draft PR xgo-dev#2269: xgo-dev#2269. Dependent PRs remain untouched until this root layer is reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of xgo-dev#2164.
Fixed targets previously set
AlwaysOmitand passed-Sunconditionally, so-ldflags=-w=falsecould not produce a debug ELF. Once retention is enabled, directld.lldtargets also must not receive the clang-only-gdwarf-4link option.This change:
.binbytes as its stripped control.Validation:
internal/crosscompileand relevantinternal/buildtests; fullinternal/buildsuite passed with the pre-existing hangingTestRunPrintfWithStdioNobufexcluded (76.2% package coverage, changed policy functions 100%);internal/crosscompileandinternal/buildtests passed;cortex-m-qemubuild: explicit-w=falseretains.debug_info, current default omits it.