fix(breakpoints)!: target the requesting iframe - #2950
Conversation
BundleMonUnchanged files (3)
No change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
|
this all thing doesn't seams to be a good idea anymore #2806 (comment) did you speak with @zatteo about iframe messaging? |
I add the topic of "resizing of iframe related to useBreakpoints" in the topic related to File Picker. We may need a more general approach but we need to think to what extend our other Flutter/Calendar apps are concerned. But if it solve an issue right now, let's merge this kind of fix (taking into account the BC). |
bfeeb1f to
61b244e
Compare
61b244e to
527fc48
Compare
|
@doubleface for the BC I prefere something really specific to avoid any thought. Could you please add this in the BC message? So you must use |
The parent breakpoint bridge assumed the intent occupied a fixed frame index. This crashed when the requesting intent was the first or only iframe. Keep the message source and send initial and resized widths back to that window. Closes #2949 BREAKING CHANGE: replace the old hook usage with: const { iframeWindow } = useIframeConnection({ parentBasedIframe }) useIframeToSendWidth({ iframeWindow })
527fc48 to
02e2919
Compare
Done |
|
🎉 This PR is included in version 141.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Add gap utilities and fix iframe breakpoint targeting cozy-ui 140.5.2 → 141.0.0 - cozy/cozy-ui#2281 - cozy/cozy-ui#2950
Add gap utilities and fix iframe breakpoint targeting cozy-ui 140.5.2 → 141.0.0 - cozy/cozy-ui#2281 - cozy/cozy-ui#2950
Add gap utilities and fix iframe breakpoint targeting cozy-ui 140.5.2 → 141.0.0 - cozy/cozy-ui#2281 - cozy/cozy-ui#2950
Add gap utilities and fix iframe breakpoint targeting cozy-ui 140.5.2 → 141.0.0 - cozy/cozy-ui#2281 - cozy/cozy-ui#2950
Add gap utilities and fix iframe breakpoint targeting cozy-ui 140.5.2 → 141.0.0 - cozy/cozy-ui#2281 - cozy/cozy-ui#2950
Add gap utilities and fix iframe breakpoint targeting cozy-ui 140.5.2 → 141.0.0 - cozy/cozy-ui#2281 - cozy/cozy-ui#2950
Add gap utilities and fix iframe breakpoint targeting cozy-ui 140.5.2 → 141.0.0 - cozy/cozy-ui#2281 - cozy/cozy-ui#2950
Add gap utilities and fix iframe breakpoint targeting cozy-ui 140.5.2 → 141.0.0 - cozy/cozy-ui#2281 - cozy/cozy-ui#2950
Summary
Send parent breakpoint widths to the iframe that requested them instead of relying on a fixed frame index.
Breaking change: replace the old hook usage with:
Closes BreakpointsProvider crashes when a parent-based iframe is the only iframe #2949.