Skip to content

[COVAL-7886] fix: preserve review project skippable metric selections - #139

Merged
callumreid merged 2 commits into
mainfrom
chore/weekly-api-parity
Oct 19, 2026
Merged

callumreid merged 2 commits into
mainfrom
chore/weekly-api-parity

Conversation

@callumreid

@callumreid callumreid commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor
  • Add --skippable-metric-ids and JSON request support to review-project creation and updates. Preserve the difference between an omitted setting, an empty list (none eligible), and explicit null (all linked metrics eligible).
  • Reconcile Monday's API parity report: all 451 published request fields on covered commands are modeled; 119/186 operations have first-class commands and the remaining 67 are existing reviewed exceptions.
  • Regression reproduced on 73ba74b before the fix: JSON metric selections were silently dropped. Request capture tests now cover both endpoints, arrays, empty arrays, null, flag values and omitted PATCH settings. Validation: cargo fmt, clippy, 217 Rust tests, 63 automation tests, Python lint/format and live API coverage audit. One unrelated update-notification test timed out with default parallelism; rerun with four test threads passed.

Comment thread api-coverage-report.md Outdated
@callumreid callumreid changed the title chore(cli): reconcile weekly API parity [COVAL-7886] fix: preserve review project skippable metric selections Oct 19, 2026
@callumreid
callumreid merged commit f5f6d16 into main Oct 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants