Repository navigation
[BENCH-1225] Serve Corral's ID Roulette tools from the mock tool server - #787
Merged
Merged
Conversation
Platform agents can call Cale's lookup tool, and Coval gets the same character error rate span Corral sends.
seribaymadina
marked this pull request as ready for review
October 29, 2026 00:12
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
coval-cale
previously approved these changes
Oct 29, 2026
coval-cale
left a comment
coval-cale
left a comment
Contributor
There was a problem hiding this comment.
Nice work, this is clean and the tests are good. Approving. A few architecture things inline worth thinking about, none of them block merge. The two I actually care about are the first-call dedup and the committed answer key.
seribaymadina
enabled auto-merge
October 30, 2026 22:42
callumreid
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms can now call
/mock?suite=id_rouletteand get the same tool answers Corral uses. Each simulation's first lookup is scored with Corral's character error rate check and sent to Coval as the samecharacter_error_ratespan Corral sends, so one Coval metric reads platforms and Corral alike. Thetools.jsonis a copy of Corral's until the scenario is published as an asset; dental stays the default suite.