Repository navigation
[BENCH-1224] Forward the Reson8 model id as a query param - #786
Merged
Merged
Conversation
seribaymadina
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reson8 asked us to try
model=rumble-2on the US endpoint, and the provider had no way to send it: the websocket URL never carried a model at all.modelquery param, minus the-globalrouting suffix.realtimeandrealtime-globalrows parameter-free. The server rejectsmodel=realtimewith a 400, so that name is ours, not a vendor id.Verified against the live endpoint: rumble-2 transcribes the sample clip identically to the default, and an unknown name gets a 400. After this lands, rumble-2 goes in as an unpublished row.
Linear: https://linear.app/coval/issue/BENCH-1224