Skip to content

Gate signal handling stderr behind env var #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
borrrden merged 4 commits into from
Jun 20, 2026
Merged

Gate signal handling stderr behind env var #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48ae985
Gate signal handling stderr behind env var
borrrden Jun 20, 2026
be0af60
Remove LiteCore includes from this file
borrrden Jun 20, 2026
e504ccf
Use clang for CI checks on Ubuntu
borrrden Jun 20, 2026
12df93d
Windows has getenv but not setenv???
borrrden Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,16 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
include:
- os: ubuntu-latest
cc: clang
cxx: clang++
- os: macOS-latest
- os: windows-latest
runs-on: ${{ matrix.os }}

env:
CC: ${{ matrix.cc }}
CXX: ${{ matrix.cxx }}

steps:
- uses: actions/checkout@v2
Expand Down
3 changes: 2 additions & 1 deletion Fleece/Support/Backtrace+capture-posix.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,8 @@ namespace signal_safe {
#endif

if ( fd != -1 ) write(fd, str, n ? n : strlen(str));
write(STDERR_FILENO, str, n ? n : strlen(str));
if (getenv("CBL_BACKTRACE_TO_STDERR") != nullptr)
write(STDERR_FILENO, str, n ? n : strlen(str));

#ifdef __clang__
# pragma clang diagnostic pop
Expand Down
5 changes: 5 additions & 0 deletions Tests/SupportTests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,11 @@ namespace test::backtrace {
TEST_CASE("Backtrace crash", "[.BacktraceManual]") {
// Since this test crashes the process intentionally,
// It will fail and require manual inspection of stderr
#ifdef _MSC_VER
SetEnvironmentVariable("CBL_BACKTRACE_TO_STDERR", "1");
#else
setenv("CBL_BACKTRACE_TO_STDERR", "1", 1);
#endif
test::backtrace::crashOnPurpose();
}

Expand Down
Loading