Skip to content

Fixed a compile error in AtomicRefCounted tests #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pasin merged 2 commits into from
Jun 18, 2026
Merged

Fixed a compile error in AtomicRefCounted tests #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd22b47
Fixed a compile error in CI on Ubuntu+Clang
snej Jun 18, 2026
33c458a
AtomicRetained fix for 32-bit(!) CPUs
snej Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Fleece/Support/RefCounted.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ namespace fleece {
namespace internal {
/// Tag bit that's added to `_ref` while accessing it.
/// We can't use the low bit (1) because mutable Fleece Values already use that as a tag.
static constexpr uintptr_t kBusyMask = uintptr_t(1) << 63;
static constexpr uintptr_t kBusyMask = uintptr_t(1) << (8 * sizeof(uintptr_t) - 1);

AtomicWrapper::AtomicWrapper(uintptr_t ref) noexcept
:_ref(ref)
Expand Down
2 changes: 1 addition & 1 deletion Tests/SupportTests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ struct AtomicRetainedTest : RefCounted {

TEST_CASE("AtomicRetained") {
// This is mostly to check for compile errors.
AtomicRef r = new AtomicRetainedTest();
AtomicRef<AtomicRetainedTest> r = new AtomicRetainedTest();
CHECK(r->i == 0);
AtomicRetained r2 = r;
AtomicRetained r3 = std::move(r2);
Expand Down
Loading