Upgrade to Spring Boot 4.0.1 with latest dependencies #138
Conversation
- Spring Boot: 3.5.5 → 4.0.1 - springdoc-openapi: 2.8.5 → 3.0.1 - Couchbase Java SDK: 3.7.9 → 3.10.0 - Lombok: 1.18.38 → 1.18.42 - maven-surefire-plugin: 3.5.2 → 3.5.4 - maven-failsafe-plugin: 3.5.2 → 3.5.4 - Removed spring-tx dependency (managed by Spring Boot parent) Spring Boot 4 migration changes: - Removed SecurityAutoConfiguration exclusion (class moved in Spring Boot 4) - Updated TestRestTemplate import to org.springframework.boot.resttestclient - Added @AutoConfigureTestRestTemplate annotation to test classes - Removed DataRetrievalFailureException from catch blocks (not needed with raw SDK) - Added spring-boot-starter-webmvc-test and spring-boot-starter-restclient test deps - Enabled springdoc-openapi (disabled by default in 3.x)
Summary of ChangesHello @teetangh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant upgrade of the project's core framework, moving from Spring Boot 3.5.5 to 4.0.1. This update brings all associated dependencies to their latest stable versions and addresses breaking changes introduced in Spring Boot 4, particularly in how testing utilities and security configurations are handled. The goal is to ensure the application remains current with the latest Spring ecosystem, benefiting from performance improvements, new features, and security patches. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively upgrades the project to Spring Boot 4.0.1 and updates several other dependencies to their latest versions. The changes are well-documented in the pull request description, covering necessary adjustments in the application code, test configurations, and properties for the major version bump. The migration steps, such as updating TestRestTemplate usage and removing obsolete configurations, have been correctly applied. My review focuses on improving the maintainability of the pom.xml by suggesting the use of properties for dependency and plugin versions, which will make future updates easier and less error-prone. Overall, this is a solid upgrade.
- Add lombok.version property and use it in dependency and annotation processor - Add springdoc.version property and use it in springdoc-openapi dependency - Update mavensurefire.version to maven-surefire.version with value 3.5.4 - Use maven-surefire.version for both surefire and failsafe plugins (same release) - Remove unused swagger.version and springweb.version properties
|
Addressed all Gemini code review comments in commit 33c2fc5:
|
Summary
This PR upgrades the project from Spring Boot 3.5.5 to Spring Boot 4.0.1 along with all dependencies to their latest versions. This is a major version upgrade that supersedes and consolidates all open Dependabot PRs.
Dependency Updates
Spring Boot 4 Migration Changes
Application.java
SecurityAutoConfiguration.classexclusion (class has been moved/removed in Spring Boot 4)Integration Tests
TestRestTemplateimport fromorg.springframework.boot.test.web.client.TestRestTemplatetoorg.springframework.boot.resttestclient.TestRestTemplate@AutoConfigureTestRestTemplateannotation to all test classesDataRetrievalFailureExceptionfrom catch blocks (not needed since this project uses raw Couchbase SDK, not Spring Data)Dependencies
spring-boot-starter-webmvc-test(test scope) - required for Spring Boot 4 testingspring-boot-starter-restclient(test scope) - required for TestRestTemplate in Spring Boot 4Configuration
application.propertiesto reflect Spring Boot 4.0+Supersedes Dependabot PRs
Test Plan