Conversation
Looks like we accidentally did not set up the CI to work on the entire workspace. It was therefore running only for the main crate, and in the meantime we merged a few changes that were breaking the tests. This fixes both the CI and the broken tests.
There was a problem hiding this comment.
Pull request overview
This PR updates the Rust CI pipeline to run checks across the entire Cargo workspace and fixes workspace-wide test/doc-test failures that were previously missed when CI only exercised the root crate.
Changes:
- Run doc tests for all workspace members and run clippy across the workspace.
- Fix rustdoc examples/doctests so workspace doc testing succeeds.
- Enable
serde’sderivefeature forcot-site-commonto support#[derive(Deserialize)].
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
cot-site-macros/src/md_pages/rendering.rs |
Marks non-Rust rustdoc examples as text to prevent failing doctests. |
cot-site-common/src/utils.rs |
Adds hidden use cot_site_common::Version; imports so doctests compile. |
cot-site-common/Cargo.toml |
Enables serde derive feature needed for Deserialize derives in this crate. |
.github/workflows/rust.yml |
Runs doc tests and clippy across the workspace (instead of only the root crate). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
56
to
+57
| - name: Test docs | ||
| run: cargo +${{ matrix.rust }} test | ||
| run: cargo +${{ matrix.rust }} test --workspace --doc |
seqre
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like we accidentally did not set up the CI to work on the entire workspace. It was therefore running only for the main crate, and in the meantime we merged a few changes that were breaking the tests.
This fixes both the CI and the broken tests.