Skip to content

Add copy button for codeblocks#86

Open
ElijahAhianyo wants to merge 3 commits intomasterfrom
elijah/aopy-block-copy-button
Open

Add copy button for codeblocks#86
ElijahAhianyo wants to merge 3 commits intomasterfrom
elijah/aopy-block-copy-button

Conversation

@ElijahAhianyo
Copy link
Copy Markdown
Contributor

Screen.Recording.2026-04-16.at.9.17.56.PM.mov

@ElijahAhianyo ElijahAhianyo requested review from m4tx and seqre April 16, 2026 21:30
@ElijahAhianyo ElijahAhianyo changed the title Add copy to button for codeblocks Add copy button for codeblocks Apr 16, 2026
Copy link
Copy Markdown
Member

@m4tx m4tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the issues I've mentioned are resolved.

Comment thread cot-site-macros/src/md_pages/rendering.rs Outdated
Comment thread templates/_base.html Outdated
Comment thread static/static/js/code-copy.js Outdated
@ElijahAhianyo ElijahAhianyo requested a review from m4tx April 27, 2026 14:40
Comment thread templates/guide.html
</div>
</div>

{% block scripts %}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we add a new block here? It doesn't seem like we overwrite a block from the parent, and we don't overwrite this new block anywhere else either, so this just looks redundant now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants