fix(permissions): deny safe-read auto-approval for shell redirections - #85
Closed
SeashoreShi wants to merge 1 commit into
Closed
fix(permissions): deny safe-read auto-approval for shell redirections#85SeashoreShi wants to merge 1 commit into
SeashoreShi wants to merge 1 commit into
Conversation
Author
|
Friendly ping: this security fix (safe-read auto-approval bypass via shell redirection) is still open with a clean mergeable state. The branch is based on an older |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing: the same fix (redirection detection in safe-read auto-approval) was merged upstream in #111 (
isSafeReadSegmentnow rejects>,>>,<,<<,&>segments). Our branch is now redundant. Thanks!