fix: preserve reasoning in short-term memory replay - #30
Open
MackDing wants to merge 2 commits into
Open
Conversation
Author
|
Quick follow-up: this PR appears mergeable from my side, and I do not see a failing required check. Happy to make any maintainer-preferred tweak if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Issue #24 reports provider failure:
The reasoning_content in the thinking mode must be passed back to the API.The agent already storesresult.reasoning, but replaying short-term memory previously sent only assistant text back to the model. Providers that require prior thinking content can reject the next turn when that context is dropped.Relationship to #29
#29 enables thinking for DeepSeek models routed through OpenAI-compatible providers. This PR is complementary: it replays captured reasoning on later turns. The two PRs cover different stages and are not duplicates.
Validation
npm run typechecknpm test(69 tests passed)npm run buildCloses #24