clean up cortex_distributor_ingester_push_timeouts_total #7229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
reviewed
Jan 22, 2026
pkg/distributor/distributor.go
Outdated
| d.incomingMetadata.DeleteLabelValues(userID) | ||
| d.nonHASamples.DeleteLabelValues(userID) | ||
| d.latestSeenSampleTimestampPerUser.DeleteLabelValues(userID) | ||
| d.distributorIngesterPushTimeoutPerUser.DeleteLabelValues(userID) |
Contributor
There was a problem hiding this comment.
Why this metric needs to be per user?
Contributor
There was a problem hiding this comment.
When there is a push timeout, usually it is not because of data ingested from a specific user, it is more like a problem between ingester and distributor fleet. Then basically all users in the cluster will be impacted. I don't see much a value here to make this metric per tenant
Member
Author
There was a problem hiding this comment.
It makes sense, I deleted userID label in this PR.
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
clean-up-cortex_distributor_ingester_push_timeouts_total
branch
from
79f3e4f to
6c95e88
Compare
friedrichg
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed up #7155, clean up
cortex_distributor_ingester_push_timeouts_totalfor inactive user.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]