A/B probe (do not merge): lsp cold-start only - #182
Closed
ualtinok wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single-commit probe off green base 566bcde: 0904eee (notify_file_changed_if_running). Windows dead-code manifest test verdict wanted.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Avoid cold-starting LSP servers after file writes. Post-write notifications now only target servers that are already running; interactive requests still start servers when needed.
LspManager::notify_file_changed_if_runningto send updates only to running servers.AppContext::lsp_notify_file_changedto the new method to prevent cold starts after mutations.Written for commit d7bf9a5. Summary will update on new commits.