A/B probe (do not merge): flush reorder only - #181
Closed
ualtinok wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single-commit probe off green base 566bcde: f957d38 (flush pending before runtime maintenance). Windows dead-code manifest test verdict wanted.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Reordered the tick to flush ready pending responses before runtime maintenance, then flush again after using the same context. This ensures pending responses are written deterministically and fixes ordering issues seen on Windows.
write_ready_pending/write_ready_pending_to_writerbeforedrain_runtime_events, then again after; accumulate writes.ctxonce to avoid context changes mid-tick.tick_flushes_ready_pending_before_runtime_maintenancetest and updated poll count expectations.Written for commit 23f2813. Summary will update on new commits.