Open
Conversation
Signed-off-by: George Gaál <gb12335@gmail.com>
Signed-off-by: George Gaál <gb12335@gmail.com>
Member
|
This PR copies documentation from docs.coroot.com into the Helm chart READMEs. That means we'll need to maintain the same content in multiple places, which isn’t something we want to do |
Author
|
the helm documentation should be self-sufficient and clear from helm chart - what are the parameters and how they could be changed. The take regarding "multiple copies" could be solved by autogenerating the documentation from one place. You even have the documentation embedded in CRD: So I definitely could not support this claim. There should as much "instances" of documentation as necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.