Repository navigation
Conversation
Nowcast never used the summary-to-detail Use/Make methods; only CAP_HAP 2014/2020 nested them. Keep CAP_HAP 2017 and BEA_Summary_Use_SUT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc:
Closes: #1176
What changed? Why?
Removes the unbalanced summary-to-detail Make/Use FBS methods (
Detail_Use_SUT,Detail_Use,Detail_Make). The nowcast path never used them: Supply seeds fromDetail_Supply_Mix_*, and Use isBalanced_Detail_Use_SUT. Their only live nests were CAP_HAP 2014 and 2020, which this change retires (sector methods plus national/state wrappers). CAP_HAP 2017 stays onBEA_Detail_Use_SUT. Drops catalog-only orphansBEA_Summary_Use_PRO_BeforeRedefandBEA_Summary_Make_BeforeRedef; keepsBEA_Summary_Use_SUTbesideBEA_Summary_Supply. Updatesanalysis/nowcasting/plan.mdso Use-side fallback language no longer points atDetail_Use_SUT.Any later CAP_HAP 2014/2020 (or other year) rebuild should attribute from nowcast balanced Use (
Balanced_Detail_Use_SUTor an equivalent nowcast-derived product), not from these retired summary-to-detail FBS methods.Impact
No USA / nowcast / MUT / EF output change; those paths never called the deleted methods.
Testing
rgconfirms no remaining!includeofDetail_Use_SUT.yaml,Detail_Use.yaml, orDetail_Make.yaml, and CAP_HAP 2014/2020 wrappers are gone.