Skip to content

cleanup: remove leftover CEDA schema bridging and appliance 4-way special-casing - #1300

Open
bl-young wants to merge 3 commits into
mainfrom
by-cleanup-ceda-appliances
Open

bl-young wants to merge 3 commits into
mainfrom
by-cleanup-ceda-appliances

Conversation

@bl-young

Copy link
Copy Markdown
Member

cc:
Closes: #1151

What changed? Why?

Production is Cornerstone-only (335220 for major household appliances). This removes dead CEDA allocator/Make-Use helpers, orphan FlowSA targets and activity-to-sector crosswalks, unused USDA/PCE CEDA parsers, unused CEDA_COUNTRY* taxonomy, and the unused 2012 CEDA6IO loaders. Live MECS industry maps use native 335220 keys (no import-time remapper), and the price-index detail name map remaps leftover 2012 appliance names to 335220 and pump equipment from 33391A to 333914.

Removed entry points (none were selected by USA model or waterfall configs): extract/allocation/bea.py Make/Use/PCE loaders and CEDA aligners; FlowSA method CEDA_2025_target plus Sector_Crosswalk_*_CEDA CSVs; regenerate USDA_CoA_Cropland_CEDA / USDA_CoA_Livestock_CEDA / BEA_PCE_CEDA FBAs; import extract.iot.io_2012 or utils.taxonomy.countries. CEDA-named waterfalls (v03_waterfall_ceda_g1a / g1b) and diagnostic CEDA/USEEIO alignment stay runnable.

Impact

No model output change: MECS exported maps match the prior keys as sets, and configured GO/PI vintages already use the aggregate appliance and 333914 names.

Testing

Unit coverage for mapping-name collection and Cornerstone MECS manufacturing coverage; Black and Ruff clean at repo root.

uv run pytest bedrock/utils/config/__tests__/test_diff_methods.py bedrock/transform/allocation/__tests__/test_mecs_mapping.py -v -m "not eeio_integration"
uv run black --check .
uv run ruff check .

Review focus

  • Confirm diagnostic CEDA/USEEIO paths (diagnostics_helpers, ceda_v7, waterfall decks) are untouched on purpose
  • Spot-check PRICE_INDEX_DETAIL_NAME_TO_BEA_2017_INDUSTRY_MAPPING appliance and pump remaps keep vintage labels as keys

…folding

Drop dead CEDA allocator/extract/crosswalk assets and flatten live MECS
and price-index maps onto Cornerstone 335220 / 333914. Closes #1151.
@bl-young bl-young added the cleanup Code to be cleaned up label Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code to be cleaned up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cleanup: remove leftover CEDA schema bridging and appliance 4-way special-casing

1 participant