Use the bot's localpart, unchanged, for the default room workspace - #208
Merged
Merged
Conversation
bot_agent_name() capitalised the Matrix localpart, so bot_default_cwd() fell back to ~/Cornelius and created it, while cerebro runs the bot from ~/cornelius. The name is now the localpart as written, which matches the instance directory for bots whose localpart is all lowercase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bot_agent_name()capitalised the Matrix localpart, sobot_default_cwd()fell back to~/Corneliusand created it, while cerebro runs the bot from~/cornelius. The name is now the localpart as written, and the fallback matches the instance directory for bots whose localpart is all lowercase. An instance directory with other capitalisation, such as~/LilCasey, was mismatched before and still is.matrix: topic cwd /home/troy/cornball_ai does not exist; falling back to /home/troy/Cornelius. The topic path is a separate, room-side fix.subagent-async-defaultbranch also carries a 0.7.1.48 bump, so whichever merges second needs a re-bump.Test plan
test_rooms.R: the threebot_agent_name()expectations now assert the lowercase localpart. 272 asserts pass.test_rooms_reactions.R, which exercisesbot_default_cwd()and the topic fallback: 72 asserts pass.R CMD INSTALL --library.