Restore corteza.tools after the instruction catalog tests - #207
Merged
Merged
Conversation
session_setup(tools = "run_r") writes the process-global corteza.tools option and nothing put it back, so test_mcp_handler.R saw one tool and its subagent visibility assertion failed whenever the files ran in order. The restore goes through base::options on purpose: tinytest masks options() inside a test file and re-applies at file end whatever the masked call saw as the prior value, and session_setup() sets the option through base, invisible to that mask, so a masked restore was recorded as the change and undone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_instruction_catalog.Rcallssession_setup(tools = "run_r"), which writes the process-globalcorteza.toolsoption, and never put it back.test_mcp_handler.Rthen saw one tool and its subagent visibility check failed whenever the files ran in order, which is every CI run.on.exit, throughbase::options. tinytest masksoptions()inside a test file and re-applies at file end whatever the masked call saw as the prior value;session_setup()sets the option through base, so a masked restore was recorded as the change and undone. The comment in the test says so.Test plan
corteza.tools = "run_r"and the handler fails 1 of 42.