Wire Slack channel lifecycle - #14
Merged
Merged
Conversation
chat_channel_create.chat_slack posts conversations.create, with adapter options (is_private) riding through ... into the body, and returns the name from Slack's answer, since names are what every other verb in this adapter takes. chat_leave.chat_slack posts conversations.leave. Refusals propagate through slack_stop_for_error in both directions: no phantom channels, no phantom departures. The created channel is not added to the poll set; channels= is fixed at construction, the same bargain chat_join() makes.
chat_channel_create.chat_slack and chat_leave.chat_slack carried @export tags but NAMESPACE was never regenerated, so the installed package fell through to the default method and the Slack tests failed under R CMD check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13, which added
chat_channel_create()/chat_leave()with the Slack flags honestly FALSE. This wires them.chat_channel_create.chat_slackpostsconversations.createthrough the same.apiseam the other read/control verbs use. Adapter options (is_private = TRUE) ride through...into the request body. The return value is the name from Slack's answer, since names are what every other verb in this adapter takes (matchingchat_join). Slack's naming rules are enforced by the API and its refusal propagates (name_taken,invalid_name) rather than being pre-normalized away.chat_leave.chat_slackpostsconversations.leave;not_in_channelpropagates, so a failed leave never masquerades as a quiet success.channels =is fixed at construction, the same bargainchat_join()makes, and the method comment says so.991 tests pass, including seam-injected request-shape checks (path, method, body placement — body, not dots, since
call_slack_api()drops dots on POST) and refusal propagation for both verbs.