Check errcode in ILinkClient::api_post#71
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves Rust SDK error handling for iLink API calls by treating non-zero errcode responses as failures even when the HTTP status is successful.
Changes:
- Add
errcode != 0checking inILinkClient::api_postand returnWeChatBotError::Apion API-level failures. - Update
Cargo.lockto reflect thewechatbotcrate version0.3.1.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rust/src/protocol.rs | Adds API-level errcode validation in api_post so callers don’t silently accept error responses with HTTP 200. |
| rust/Cargo.lock | Locks crate version update to 0.3.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+236
to
+240
| message: value["errmsg"] | ||
| .as_str() | ||
| .or_else(|| value["message"].as_str()) | ||
| .unwrap_or(&text) | ||
| .to_string(), |
There was a problem hiding this comment.
The error message extraction here (errmsg -> message -> raw text) differs from the earlier status >= 400 branch, which only checks errmsg. Consider extracting a small helper/closure to compute the API error message once and reusing it in both branches to keep behavior consistent and avoid duplicated parsing logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.