Skip to content

fix(sparql): apply AST simplification for nested OPTIONAL group filte… - #619

Merged
remiceres merged 2 commits into
feature/corese-nextfrom
feature/613-query-respect-filter-scope-in-nested-group-graph-patterns
Oct 2, 2026
Merged

remiceres merged 2 commits into
feature/corese-nextfrom
feature/613-query-respect-filter-scope-in-nested-group-graph-patterns

Conversation

@abdessamad-abdoun

Copy link
Copy Markdown
Contributor

…r scoping (#613)

WhereCompiler.compileGroup() is restored to its original form; the transformation now lives entirely at the AST layer.

…r scoping (#613)

WhereCompiler.compileGroup() is restored to its original form; the transformation now lives entirely at the AST layer.
@github-actions

Copy link
Copy Markdown
Overall Project 55.71% 🍏
Files changed 99.16% 🍏

File Coverage
AstSimplifier.java 99.04% -0.96% 🍏
WhereCompiler.java 97.44% 🍏

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Test Results

  448 files    448 suites   22s ⏱️
3 174 tests 3 174 ✅ 0 💤 0 ❌
3 193 runs  3 193 ✅ 0 💤 0 ❌

Results for commit ae71654.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Overall Project 55.69% 🍏
Files changed 100% 🍏

File Coverage
WhereCompiler.java 97.41% 🍏
NativeAggregateEvaluator.java 71.37% 🍏

@remiceres remiceres left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Implémentation propre au niveau de l'AST et couverture complète par les tests unitaires.

@remiceres
remiceres merged commit 25aa0ab into feature/corese-next Oct 2, 2026
2 checks passed
@remiceres
remiceres deleted the feature/613-query-respect-filter-scope-in-nested-group-graph-patterns branch October 2, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Query] Respect filter scope in nested group graph patterns (dawg-optional-filter-005-simplified)

2 participants