fix: build artifacts for Git installs - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Git dependency installed from the standalone Channel repository had no committed
dist/**files and no lifecycle build, so its declared renderer and service entries were missing. Add the standard npmpreparehook to build both artifacts after dependencies are installed.Validation:
npm run check(16/16 tests)npm pack --dry-runcontainsdist/channel.jsanddist/service.mjs2a3a2e86af489fa92156be787f6e6cf1b4506474produced both entries (42,024-byte renderer and 2,164-byte service)