Repository navigation
fix(adapter): return SSH string length errors instead of panicking - #8
Merged
Merged
Conversation
When converting SSH string lengths to uint32, sshString panicked on overflow. Return ([]byte, error) instead and propagate wrapped errors naming each field across OpenSSH key blob generation and review receipt signing. Handle errors when generating the allowed_signers document during bundle writing. Add test coverage verifying that SSH string length overflow returns an error naming the affected field without panicking. Signed-off-by: lusoris <lusoris@proton.me>
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/knowledge-adapter-v2 built SSH strings with a checked length conversion that panicked on overflow, which HISS-07 forbids in production code. sshString now returns an error, and every caller wraps it with the field it was building; output for valid input is unchanged.
Order: engine-adoption-knowledge-gosec-debt-20261023