Large-tree deep link: 'Proceed anyway' override - #58
Merged
Conversation
Over the 100 MB browser limit, the ?pb= fetch now shows a warning with a Proceed
anyway button that loads the tree with the size guard bypassed, rather than erroring
out. fetchPbAsFile gains a { force } option and throws a typed TOO_LARGE error the
launcher catches to render the override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
?pb=<url>tree exceeds the 100 MB browser limit, show a warning with a Proceed anyway button (loads it with the guard bypassed) instead of hard-failing. Useful on the Vercel/backendless site where a user knows their machine can handle it.fetchPbAsFilegains{ force }; over-limit throws a typedTOO_LARGEerror carrying the size.proceedLargeTreere-fetches withforce: true.Verified end-to-end (temporarily lowered the threshold so a small tree tripped it): warning + button render, Proceed loads the tree, Run Pipeline works. Frontend-only.
Merging deploys to Vercel.