Repository navigation
Wire tier3 (stale-facts) into repo_slim handoff - #26
Merged
Merged
Conversation
handoff now emits a third ledger proposal batch for tier3 (fix-stale-facts) findings, alongside tier1 (delete) and tier2 (merge) — one proposal per non-empty tier, same as before. Unlike tier1/tier2, each finding's own evidence (the exact dead reference) is folded into the rationale, since a fix needs to know WHAT to change, not just where; the proposal title and rationale call out that this is a docs fix, not a delete or merge. computePlanHash now also hashes tier3 (path + evidence), so the handoff gate protects tier3 too — a stale-facts-only change (no tier1/tier2 delta) still invalidates a prior planHash. Removed the "handoff does not yet produce a proposal for tier3" note from NOT_IMPLEMENTED and the tool description, since it's no longer true. Ran scan/plan/handoff against chime's own repo before finalizing (same real-world-scrutiny step as prior PRs) — all three tiers empty, handoff returns an empty proposal set cleanly, no regressions. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handoffnow emits a third ledger proposal batch fortier3FixStaleFacts, alongsidetier1(delete) andtier2(merge) — one proposal per non-empty tier, same pattern as before.tier1/tier2, each finding's ownevidence(the exact dead reference) is folded into the rationale — a fix needs to know what to change, not just where. The title and rationale explicitly call out that this is a docs fix, not a delete or merge.computePlanHashnow also hashestier3(path + evidence), so the planHash gate protects it too: a stale-facts-only change (no tier1/tier2 delta) still invalidates a prior planHash and forces a freshplancall.notImplementedand the tool description — no longer true.Test plan
npm run check(tsc) — cleannpm test— 218/218 passing. Updated 2 existing tests whose assertions were about the old "tier3 not proposed" behavior; added a dedicated tier3-proposal test and a planHash-protects-tier3 regression test; extended the "one proposal per tier" test to exercise all three tiers together.scan→plan→handoffagainst chime's own repo (same throwaway-fixture approach as prior PRs) — all three tiers empty,handoffreturns a clean empty proposal set, no regressions.🤖 Generated with Claude Code