Conversation
Add comprehensive tests to freeze API signatures across all reexport files: - Type hierarchy checks for inheritance relationships - Method signature checks with has() for key functions - Missing symbols: solve and plot! now properly tested - All 503 reexport tests passing This will detect breakages when CTX packages change their APIs. Files modified: - test/suite/reexport/test_ctbase.jl: exception inheritance - test/suite/reexport/test_ctdirect.jl: discretizer hierarchy + discretize signature - test/suite/reexport/test_ctflows.jl: Hamiltonian types + Lift/Flow signatures - test/suite/reexport/test_ctmodels.jl: plot! + OCP types + serialization signatures - test/suite/reexport/test_ctsolvers.jl: solver/modeler/parameter hierarchy + DOCP signatures - test/suite/reexport/test_optimalcontrol.jl: solve + methods signatures
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive tests to freeze API signatures across all reexport files:
This will detect breakages when CTX packages change their APIs.
Files modified: