fix: Coderabbitai findings

[contre95]

Summary by CodeRabbit

• Bug Fixes

  • Prevented crashes and incorrect behavior when artist metadata is missing or nil.
  • Fixed handling of empty/zero-byte files so import failures show appropriate messages.
  • Ensured grouping UI actions only enable bulk replace for truly replaceable items.

• Improvements

  • Stricter metadata validation (treats whitespace-only fields as missing) and more reliable tag writing across formats.

[coderabbitai]

Warning

Review limit reached

@contre95, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 24 minutes and 42 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4e09a62f-d765-4129-9fa8-c49f48693147

📥 Commits

Reviewing files that changed from the base of the PR and between 9bd79c4 and 563fdbf.

📒 Files selected for processing (2)

• src/features/importing/handlers.go
• src/features/importing/service.go

📝 Walkthrough

Walkthrough

Adds defensive checks and whitespace-trimming for metadata: introduces firstValidArtist and safeArtistName, applies them in download jobs and tag writers, reorders import defaults to run earlier, hardens import error messages, and narrows grouped-replace UI eligibility to replaceable items.

Changes

Defensive artist metadata null-safety refactoring

Layer / File(s)	Summary
Core metadata validation and defaults src/music/track.go	Introduces firstValidArtist to find the first artist with non-nil pointer and non-blank name. EnsureMetadataDefaults now uses this helper and treats whitespace-only title/genre as missing. ValidateRequiredMetadata aligns with these stricter semantics.
Download job progress and logging safety src/features/downloading/download_job.go	Adds safeArtistName helper and applies it across track/album job naming, conditional artist job metadata, and tag-related debug logging to avoid dereferencing nil artist pointers.
Tag writer artist field construction src/infra/tag/tag_writer.go	MP3 and FLAC tag writers now conditionally append artist/albumartist fields only when nested artist pointers are non-nil, replacing unconditional dereference of ar.Artist.Name.
Import flow reordering and UI/error handling src/features/importing/service.go, src/features/importing/directory_job.go, src/features/importing/handlers.go	Service.importTrack moves EnsureMetadataDefaults earlier so fallback metadata feeds destination path resolution. ProcessQueueGroup tracks processed/failed counts and errors if all attempts fail. runDirectoryImport defensively builds error messages for zero-byte files. Grouped replace UI now considers ReplaceEnabled only.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is vague and generic, using non-descriptive terms that don't convey meaningful information about what the pull request actually changes or fixes.	Replace with a specific title describing the main change, such as 'fix: Handle missing or nil artist metadata gracefully' or 'fix: Add defensive null checks for artist and metadata fields'.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/missing_metadata

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}