Skip to content

fix: Edit tag infinite rendering#167

Merged
contre95 merged 1 commit into
mainfrom
fix/edit_tag
Jun 10, 2026
Merged

fix: Edit tag infinite rendering#167
contre95 merged 1 commit into
mainfrom
fix/edit_tag

Conversation

@contre95

@contre95 contre95 commented Jun 10, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes
    • Fixed route matching to ensure the lyrics endpoint is correctly prioritized over general metadata routes, preventing request mishandling.

@contre95 contre95 merged commit 1488fe3 into main Jun 10, 2026
1 check was pending
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 69addbd6-1f54-4465-a528-4db8fae8a6f4

📥 Commits

Reviewing files that changed from the base of the PR and between d1eadef and 2fec47a.

📒 Files selected for processing (1)
  • src/features/hosting/server.go

📝 Walkthrough

Walkthrough

The PR fixes route matching priority in the Fiber web server by reordering route registration and adding documentation. The lyrics handler is now registered before the metadata routes, ensuring /tag/:trackId/lyrics matches before the more general /tag/:trackId/:provider pattern. Inline comments explain why registration order matters to prevent incorrect request capture.

Changes

Route Registration Order

Layer / File(s) Summary
Route order documentation and registration reordering
src/features/hosting/server.go
Fiber routes are reordered so /tag/:trackId/lyrics matches before the wildcard /tag/:trackId/:provider pattern. Inline documentation clarifies that more specific literal routes must be registered first to prevent wildcard routes from capturing requests incorrectly.

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/edit_tag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant