ci: run the unit-test gate on PRs to master - #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Unit Tests workflow filters
pull_requesttobranches: [main], but the repository's default branch ismaster, so the gate has never run on any PR. That's how #228 merged a notifykit bump that doesn't compile (details in #242). One-line fix: point the filter atmaster.Two things worth knowing before merging:
pathsfilter only matchesinternal/**,main.go,go.mod, andgo.sum, and this change touches none of them. The first PR that touches Go code after this merges will run the gate.internal/notifyis adapted to the new notifykit API. That's the gate working as intended, but if you'd rather not have a red window, fixing master does not compile; the PR test gate never runs #242's compile break first and merging this right after avoids it.The
workflow_callandworkflow_dispatchtriggers are untouched.Checklist
change(orbug) fits.