Add HTTP service for creating snapshots#388
Merged
BigVan merged 1 commit intocontainerd:dev/snapshotfrom Dec 23, 2025
Merged
Conversation
BigVan
reviewed
Dec 16, 2025
src/config.h
Outdated
| APPCFG_CLASS | ||
| APPCFG_PARA(enable, bool, false); | ||
| APPCFG_PARA(domainSocket, std::string, ""); | ||
| APPCFG_PARA(address, std::string, "http://0.0.0.0:12345/snapshot"); |
Member
There was a problem hiding this comment.
http://0.0.0.0:12345 is ok.
It should be used as an HTTP address for multiple functions
Member
There was a problem hiding this comment.
use '127.0.0.1' as default for security reason
src/image_service.cpp
Outdated
| return ret; | ||
| } | ||
|
|
||
| int SnapshotHandler::handle_request(photon::net::http::Request& req, |
Member
There was a problem hiding this comment.
move it to an individual file, such as 'api_server.cpp'
BigVan
reviewed
Dec 18, 2025
src/CMakeLists.txt
Outdated
| prefetch.cpp | ||
| tools/sha256file.cpp | ||
| tools/comm_func.cpp | ||
| snapshot_server.cpp |
Member
There was a problem hiding this comment.
‘api_server.cpp’ is more suitable
also, snapshot_server.h --> api_server.h
src/snapshot_server.cpp
Outdated
| limitations under the License. | ||
| */ | ||
|
|
||
| #include "snapshot_server.h" |
Member
There was a problem hiding this comment.
move it after #include "image_file.h"
src/example_config/overlaybd.json
Outdated
| "serviceConfig": { | ||
| "enable": false, | ||
| "domainSocket": "/var/run/overlaybd.sock" | ||
| "address": "http://127.0.0.1:12345" |
Member
There was a problem hiding this comment.
127.0.0.1:9862,
because the port of exporter is 9863 😂
BigVan
reviewed
Dec 18, 2025
src/config.h
Outdated
| APPCFG_CLASS | ||
| APPCFG_PARA(enable, bool, false); | ||
| APPCFG_PARA(domainSocket, std::string, ""); | ||
| APPCFG_PARA(address, std::string, "http://127.0.0.1:12345"); |
BigVan
reviewed
Dec 18, 2025
src/image_service.h
Outdated
| }; | ||
|
|
||
| struct ImageFile; | ||
| class SnapshotHandler; |
Signed-off-by: Xun Chen <xunchen@hust.edu.cn>
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces an HTTP service for creating snapshots.
The service listens on 0.0.0.0 and handles snapshot creation requests. Upon receiving a request, it locates the corresponding image file by the given device ID and calls the image's create_snapshot() interface.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: