Skip to content

Identity Plugin - #288

Open
atpugtihsrah wants to merge 4 commits into
containerd:mainfrom
atpugtihsrah:identity-plugin-5qjelc65nb
Open

Identity Plugin#288
atpugtihsrah wants to merge 4 commits into
containerd:mainfrom
atpugtihsrah:identity-plugin-5qjelc65nb

Conversation

@atpugtihsrah

@atpugtihsrah atpugtihsrah commented Apr 24, 2026

Copy link
Copy Markdown

Identity Plugin WIP

RFC PR: #245

Relates to #240

PR Assisted by IBM Bob.

@MikeZappa87

Copy link
Copy Markdown
Member

@atpugtihsrah this is interesting. I did some work in the istio/isovalent ecosystem for SPIRE. Lmk if you need any help

@atpugtihsrah
atpugtihsrah force-pushed the identity-plugin-5qjelc65nb branch from 11f5595 to ff81182 Compare May 21, 2026 14:48
@atpugtihsrah
atpugtihsrah force-pushed the identity-plugin-5qjelc65nb branch 2 times, most recently from 0748a95 to e355b5e Compare July 12, 2026 06:44

}

// TODO create test cases for processDelegatedIdentityUpdate() No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the red dash here means no newline at end of file

@mikebrow

Copy link
Copy Markdown
Member
Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:
  Ginkgo CLI Version:
    2.28.1
  Mismatched package versions found:
    2.19.1 used by identity-injector

  Ginkgo will continue to attempt to run but you may see errors (including flag
  parsing errors) and should either update your go.mod or your version of the
  Ginkgo CLI to match.

  To install the matching version of the CLI run
    go install github.com/onsi/ginkgo/v2/ginkgo
  from a path that contains a go.mod file.  Alternatively you can use
    go run github.com/onsi/ginkgo/v2/ginkgo
  from a path that contains a go.mod file to invoke the matching version of the
  Ginkgo CLI.

  If you are attempting to test multiple packages that each have a different
  version of the Ginkgo library with a single Ginkgo CLI that is currently
  unsupported.


go 1.24.1

require (

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see https://github.com/containerd/nri/blob/main/plugins/ulimit-adjuster/go.mod#L5

suggest adding a replace in front of the requires section.. and re-vendoring

@atpugtihsrah
atpugtihsrah force-pushed the identity-plugin-5qjelc65nb branch 9 times, most recently from 9385d66 to 81b8426 Compare July 16, 2026 09:13
Signed-off-by: Harshit Gupta <hg2t4e@gmail.com>
@atpugtihsrah
atpugtihsrah force-pushed the identity-plugin-5qjelc65nb branch from 7b49520 to ec86027 Compare July 16, 2026 09:26
@atpugtihsrah
atpugtihsrah marked this pull request as ready for review July 16, 2026 09:29
@mikebrow

mikebrow commented Jul 20, 2026

Copy link
Copy Markdown
Member

good meeting this morning @atpugtihsrah! Note to other reviewers contributor is going to clean up the vendor issues and boost the plugin getting started guide.

Signed-off-by: Harshit Gupta <hg2t4e@gmail.com>
Signed-off-by: Harshit Gupta <hg2t4e@gmail.com>
Signed-off-by: Harshit Gupta <hg2t4e@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants