Identity Plugin - #288
Open
atpugtihsrah wants to merge 4 commits into
Open
Conversation
Draft
Member
|
@atpugtihsrah this is interesting. I did some work in the istio/isovalent ecosystem for SPIRE. Lmk if you need any help |
atpugtihsrah
force-pushed
the
identity-plugin-5qjelc65nb
branch
from
May 21, 2026 14:48
11f5595 to
ff81182
Compare
atpugtihsrah
force-pushed
the
identity-plugin-5qjelc65nb
branch
2 times, most recently
from
July 12, 2026 06:44
0748a95 to
e355b5e
Compare
mikebrow
reviewed
Jul 14, 2026
|
|
||
| } | ||
|
|
||
| // TODO create test cases for processDelegatedIdentityUpdate() No newline at end of file |
Member
There was a problem hiding this comment.
the red dash here means no newline at end of file
Member
|
mikebrow
reviewed
Jul 14, 2026
|
|
||
| go 1.24.1 | ||
|
|
||
| require ( |
Member
There was a problem hiding this comment.
see https://github.com/containerd/nri/blob/main/plugins/ulimit-adjuster/go.mod#L5
suggest adding a replace in front of the requires section.. and re-vendoring
atpugtihsrah
force-pushed
the
identity-plugin-5qjelc65nb
branch
9 times, most recently
from
July 16, 2026 09:13
9385d66 to
81b8426
Compare
Signed-off-by: Harshit Gupta <hg2t4e@gmail.com>
atpugtihsrah
force-pushed
the
identity-plugin-5qjelc65nb
branch
from
July 16, 2026 09:26
7b49520 to
ec86027
Compare
atpugtihsrah
marked this pull request as ready for review
July 16, 2026 09:29
Member
|
good meeting this morning @atpugtihsrah! Note to other reviewers contributor is going to clean up the vendor issues and boost the plugin getting started guide. |
Signed-off-by: Harshit Gupta <hg2t4e@gmail.com>
Signed-off-by: Harshit Gupta <hg2t4e@gmail.com>
Signed-off-by: Harshit Gupta <hg2t4e@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identity Plugin WIP
RFC PR: #245
Relates to #240
PR Assisted by IBM Bob.