Skip to content

fix: parse SS3 cursor key sequences in read_key #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lovesegfault wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −1
Open

fix: parse SS3 cursor key sequences in read_key #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/unix_term.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,26 @@ fn read_single_key_impl(fd: RawFd) -> Result<Key, io::Error> {
// \x1b[ and no more input
Ok(Key::UnknownEscSeq(vec![c1]))
}
} else if c1 == 'O' {
// SS3 (Single Shift 3) sequences. Sent by terminals in
// application cursor key mode (DECCKM, enabled via
// `ESC [ ? 1 h` / terminfo smkx). zsh's ZLE commonly
// leaves DECCKM on when running external commands.
if let Some(c2) = read_single_char(fd)? {
match c2 {
'A' => Ok(Key::ArrowUp),
'B' => Ok(Key::ArrowDown),
'C' => Ok(Key::ArrowRight),
'D' => Ok(Key::ArrowLeft),
'H' => Ok(Key::Home),
'F' => Ok(Key::End),
_ => Ok(Key::UnknownEscSeq(vec![c1, c2])),
}
} else {
Ok(Key::UnknownEscSeq(vec![c1]))
}
} else {
// char after escape is not [
// char after escape is not [ or O
Ok(Key::UnknownEscSeq(vec![c1]))
}
} else {
Expand Down
Loading