WIP: Spec for versioned field list bug - refs #665#1031
Draft
philayres wants to merge 1 commit intoconsected:developfrom
Draft
WIP: Spec for versioned field list bug - refs #665#1031philayres wants to merge 1 commit intoconsected:developfrom
philayres wants to merge 1 commit intoconsected:developfrom
Conversation
0f98b4c to
aa7eec5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: Versioned field list spec for issue #665
Status: Work in Progress — awaiting a concrete reproduction scenario from the reporter.
What this PR contains
A spec file (
spec/models/dynamic/versioned_field_list_spec.rb) that tests whether versioned dynamic model definitions correctly restrict fields to those that existed at the time a record was created.Tests cover
field_list_arrayon versioned definitions excludes new fieldsoption_type_configfields on versioned definitions excludes new fieldsedit_form_field_listfor old instances excludes new fieldsTemplateOptionMapping.dynamic_model_mappingitem_list excludes new fieldsCurrent findings
All 4 tests pass at the model layer, meaning the core versioning of
field_listworks correctly when an explicitfield_listis set. The bug likely manifests in a different scenario (e.g. blank field_list auto-detected from table columns, or in the rendering/template layer).Next steps
Refs #665