Added config library timestamp check to dynamic definition cache invalidation - fixes #523#1024
Open
philayres wants to merge 1 commit intoconsected:developfrom
Open
Added config library timestamp check to dynamic definition cache invalidation - fixes #523#1024philayres wants to merge 1 commit intoconsected:developfrom
philayres wants to merge 1 commit intoconsected:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #523. Dynamic definitions now detect YAML config library changes via
up_to_date?/refresh_outdated, ensuring stale cached configurations are refreshed across all servers and delayed_job workers.Changes
app/models/dynamic/def_handler.rblatest_stored_updatenow queriesMAX(updated_at)from both definition tables andconfig_libraries WHERE format = 'yaml', returning the greater valueup_to_date?tracks@config_library_only_changeto distinguish config-library-only changes from definition changesapp/models/dynamic/def_generator.rbrefresh_outdatedhandles config-library-only changes by callingforce_option_config_parseon definitions with# @libraryreferences — skipping full model regenerationapp/jobs/application_job.rbApplication.refresh_dynamic_defsbeforeblock.callinaround_performso delayed_job workers detect config library changesspec/models/dynamic/config_library_cache_invalidation_spec.rb(new)Acceptance Criteria Coverage