Fix Ctrl+C - #34
Fix Ctrl+C#34
Conversation
This reverts commit 0140008.
|
This breaks listening for CtrlC and other cancellation events in the flink shell, so I have to revert it. To fix the issue you have with the |
|
We actually had tried the same fix in the past and reverted it for the reason Yannick mentioned: #17 |
|
Here's how we fixed it (what Yannick also mentioned we did for flink shell): https://github.com/confluentinc/cli/blob/main/pkg/flink/app/application.go#L68 We basically store stdinBefore before starting go-prompt and restore it as part of the cleanup when exiting go-prompt :) This way we had ctrl c not bugging and listening for keystrokes also works! |
|
Here's how you could do it for the ai command: |
Started using this package for the new
confluent aicommand. Ctrl+C becomes unusable after exiting (not sure if you're seeing this inconfluent flink shellor not...) but there's an unmerged fix for it here: c-bata#239. This PR copies this commit over and I have already tested that it works!