Conversation
sellout
force-pushed
the
ghc-9
branch
2 times, most recently
from
4d1d74a to
97f03e2
Compare
This moves tests that depend on the plugin from concat-examples to concat-plugin. The one shortcoming, IMO, is that it requries duplicating the SMT flag.
Mostly trivial changes, but we now get the `DynFlags` from `installCoreToDos` rather than each application of `BuiltinRule.ru_try`. This continues to work just fine for GHC 8.10, but doesn't quite work on GHC 9.0 for some reason. I don't think it's the `DynFlags` changes (as that's applied to all GHC versions). But running on GHC 9.0 always fails with "isDeadEndId cccV" (this is slightly stricter than `isBottomingId` in earlier GHCs, but removing that `pprPanic` still fails, just with "Oops: toCcc'' called" instead). Fixes compiling-to-categories#98.
Doesn't cover the plugin yet.
sellout
pushed a commit
that referenced
this pull request
May 16, 2022
This time, re-add it for GD to unbreak compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.