Repository navigation
Raise test coverage to 93% and add Claude Code project context - #105
Merged
Merged
Conversation
- Add tests for KeyboardPane, KeyboardRegion (layout parser), KeyButtonEventHandler, key buttons, timelines, MultiKeyPopup, KeyBoardPopup and its builders, FXRobotHandler and FXOK - Add FxTestSupport: starts the JavaFX toolkit once and skips FX tests when no display is available instead of hanging until timeout - Fix crash on empty keyLabelStyle/keyIconStyle attributes, which aborted parsing of the rest of the layout - Add JaCoCo coverage report (target/site/jacoco) - CI: run tests under xvfb, upload surefire reports from all modules and the coverage report Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GVKTE7YjM5Y9LLQ8NcRuzC
…skills) Mirrors the eclipse-milo .claude layout: CLAUDE.md imports AGENTS.md, a maven-command-runner agent, focused docs for tests, conventions, docs and keyboard layouts, plus an add-keyboard-layout skill. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GVKTE7jdB7EUYDA7qUT95U
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GVKTE7YjM5Y9LLQ8NcRuzC
On CI the text field bounds include the 1.4px focus ring while the popup lands on the whole pixel, so compare with a 2px tolerance. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GVKTE7YjM5Y9LLQ8NcRuzC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by sunny · project thread
Raise test coverage to 93% and add Claude Code project context
Line coverage of
fx-onscreen-keyboardgoes from 11.2% (152/1356) to 93.0% (1263/1358), branch coverage 85.8%. 112 tests (was 4), all passing on JDK 21 under Xvfb.Changes
New tests for
KeyboardPane,KeyboardRegion(XML layout parser, all embedded layouts),KeyButtonEventHandler(every special key), the key buttons and timelines,MultiKeyPopup,KeyBoardPopupand its builders,FXRobotHandler(real key events into a focusedTextField),FXOKand moreXmlHelpercases.FxTestSupport: starts the JavaFX toolkit once, disables implicit exit, and skips FX tests when no display is available instead of hanging until the timeout (the oldKeyButtonTestbehaviour).KeyButtonTestnow uses it, and its@DisabledOnJre(JAVA_25)is removed.Bug fix: an empty
keyLabelStyleorkeyIconStyleattribute threwStringIndexOutOfBoundsExceptionand silently aborted parsing the rest of the layout. Empty values are now ignored (covered byKeyboardRegionTest.emptyStyleAttributesAreIgnored).JaCoCo 0.8.14 report bound to the
testphase (target/site/jacoco).CI: runs
mvn testunderxvfb-run, uploads surefire reports from all modules (the old path pointed at the roottarget/and was always empty), and uploads the coverage report from the JDK 17 job.Claude Code project context:
AGENTS.md,CLAUDE.md, and.claude/agents (maven-command-runner), docs (running tests, test guidelines, Java conventions, keyboard layouts, documentation) and theadd-keyboard-layoutskill. The test docs describe the newFxTestSupport,xvfb-runand the JaCoCo report.Not covered
fx-onscreen-keyboard-swingstill has no tests.KeyboardTextFieldSkin/KeyboardTextAreaSkinand the jar branch ofKeyboardLocales.Note
JDK 25 could not be tested locally. It used to be disabled because of the Monocle setup; with Xvfb it should not need Monocle, but please watch the JDK 25 CI job.
Generated by Claude Code