Skip to content

Bhatia.Ankit#5

Open
ankbhatia19 wants to merge 2 commits into
compvision:masterfrom
ankbhatia19:master
Open

Bhatia.Ankit#5
ankbhatia19 wants to merge 2 commits into
compvision:masterfrom
ankbhatia19:master

Conversation

@ankbhatia19

Copy link
Copy Markdown

No description provided.

@RobertYL

RobertYL commented Nov 3, 2018

Copy link
Copy Markdown
Contributor

Rubric:
Detection - [30%] Good.
Analysis - [20%] Good.
Structure - [18%] Followed structure to the T. Useful implementation of other helper function. However, there is redundant calculations in Target.py where the approxPolyDP is calculated a second time. This can just be passed back into the main class and used in the Target.py. But overall good.
Naming Convention - [15%] Great!
Documentation - [15%] Great! You can use # instead if ''' to comment code as well.

Overall: 98%
Amazing work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants