fix(bug): updates support for oci refs#595
Open
hbraswelrh wants to merge 2 commits into
Open
Conversation
Signed-off-by: Hannah Braswell <hbraswel@redhat.com>
hbraswelrh
force-pushed
the
opsx/fix-complypack-oci-ref
branch
from
f92a177 to
c0b6060
Compare
…aths Regenerate .gaze/baseline.json to reflect current CRAP scores after OCI ref parsing changes. The previous baseline was stale, causing 11 false regressions in CI. Also add .summary.recommended_actions[]? to the jq path-normalization filter in the crapload-baseline and crapload-check Makefile targets, preventing absolute paths from leaking into the committed baseline.
Member
Author
|
@jpower432 adding you to the reviewers since this bug was identified and discussed in your generation state PR. |
9 tasks
marcusburghardt
approved these changes
Jun 19, 2026
marcusburghardt
left a comment
marcusburghardt
left a comment
Member
There was a problem hiding this comment.
LGTM. This PR is fixing the bug and improving the situation. Thanks @hbraswelrh .
During the review I noticed some other improvement opportunities we could work in a follow-up PR: #600
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
ParsePolicyRefto hand off OCI reference parsing to the already-vendored oras-go library. The update now supports:tagand@digestsyntax in policy and complypack URLs. No new dependencies. Backwards compatible with existing@versionnotation.Related Issues
Review Hints
.devcontainer/ devpod environment..complytime/complytime.yamlworkspace configuration file withRun the commands
complyctl get# ensure fetched policies with no errorscomplyctl generate --policy-id ampel-bp# make sure all 5 requirements were generatedcomplyctl scan --policy-id ampel-bp --format pretty# look at the Markdown resultReference Results
Compliance Scan Report Results
Compliance Scan Report: complytime/policies-ampel-branch-protection
Generated: 2026-06-18T16:30:02Z
Control: force-push-restriction
block-force-push
Control: approval-requirements
minimum-approvals
Control: admin-bypass-prevention
prevent-admin-bypass
Control: code-owner-enforcement
require-code-owner-review
Control: pull-request-enforcement
require-pull-request
Evaluation Log