Skip to content

fix: harden workflow error matching and input validation #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcusburghardt merged 2 commits into from
Jul 30, 2026
Merged

fix: harden workflow error matching and input validation #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33dd1c8
fix: tighten check_suite error matching in safe-settings workaround
marcusburghardt Jul 30, 2026
5702230
fix: validate usernames before building grep pattern in drift workflow
marcusburghardt Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/peribolos-drift.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,18 @@ jobs:
# Filter expected enterprise-member drift
FILTERED_COUNT=0
if [ -n "$ENTERPRISE_MEMBERS_IGNORE" ]; then
# Validate usernames before building grep pattern.
# GitHub usernames allow only [a-zA-Z0-9-], so the values
# are safe for grep -vE without regex escaping. This guard
# fails fast if an invalid value is ever added.
for user in $(echo "$ENTERPRISE_MEMBERS_IGNORE" | tr ',' '\n'); do
user=$(echo "$user" | xargs)
[ -z "$user" ] && continue
if ! [[ "$user" =~ ^[a-zA-Z0-9-]+$ ]]; then
echo "::error::Invalid username in ENTERPRISE_MEMBERS_IGNORE: '$user'"
exit 1
fi
done
IGNORE_PATTERN=$(echo "$ENTERPRISE_MEMBERS_IGNORE" | tr ', ' '\n' \
| sed '/^$/d' | paste -sd'|' -)
BEFORE=$(wc -l < /tmp/drift-mutations.txt)
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/safe_settings_sync.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ jobs:
// exist outside the webhook flow. The sync completes
// and results are logged; only the Check Run reporting
// fails. Safe to skip.
if (String(error).includes('check_suite')) {
if (String(error).includes("Cannot read properties of undefined (reading 'check_suite')")) {
probot.log.info(
'check_suite reporting skipped (expected in full-sync mode). ' +
'See: github-community-projects/safe-settings#818'
Expand Down
Loading