Negotiate secure connection per current security configuration to rep… - #1
Open
communityds-kenneth wants to merge 1 commit into
Open
communityds-kenneth wants to merge 1 commit into
communityds-kenneth wants to merge 1 commit into
Conversation
…orting server infrastructure; resolves internal task 48115252
SonOfHarris
requested changes
Oct 15, 2018
There was a problem hiding this comment.
As those curlopts are specific to the destination they need to be specified as options rather than being hard coded. Add a $curl_options protected property on RESTRequest and then use curl_setopt_array. Set the options at the start of the setCurlOpts function to ensure a developer can not override what is already set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…orting server infrastructure; resolves internal task 48115252