change generic timeline events to show when dev mode is enabled#904
Open
jonathanmajh wants to merge 5 commits intocommetchat:mainfrom
Open
change generic timeline events to show when dev mode is enabled#904jonathanmajh wants to merge 5 commits intocommetchat:mainfrom
jonathanmajh wants to merge 5 commits intocommetchat:mainfrom
Conversation
Contributor
Author
|
Addresses #598 |
Contributor
|
I'm not sure putting them behind dev mode would be the ideal solution; personally I find it helpful to see when someone changes their display name or profile picture, and keeping dev mode on constantly isn't the most pleasant experience. I think a seperate toggle would be better? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hide various generic state events such as reactions, room joins, edit message behind dev mode flag
Left is PR, right is 0.4.1
Not sure if we want a new flag (audit mode) since dev mode can be considered a misleading to hide this behind