Skip to content

fix(ES): Jueves santo not observed in CT, VC #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
commenthol wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(ES): Jueves santo not observed in CT, VC #598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24c358d
fix(ES): Jueves santo not observed in CT, VC
commenthol Apr 8, 2026
513c331
fix(ES-NC): Santiago Apóstol is not observed
commenthol Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
51 changes: 34 additions & 17 deletions data/countries/ES.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ holidays:
# @source https://www.boe.es/boe/dias/2020/11/02/pdfs/BOE-A-2020-13343.pdf
# @source https://www.boe.es/boe/dias/2021/10/21/pdfs/BOE-A-2021-17113.pdf
# @source https://www.boe.es/buscar/doc.php?id=BOE-A-2021-17113
# @source https://www.boe.es/diario_boe/txt.php?id=BOE-A-2025-21667
# @source https://www.boe.es/buscar/act.php?id=BOE-A-1983-20906#art45
# buscar: "la relación de fiestas laborales para el año 20xx"
ES:
names:
Expand Down Expand Up @@ -33,8 +35,6 @@ holidays:
03-19:
_name: 03-19
type: observance
easter -3:
_name: easter -3
easter -2:
_name: easter -2
easter:
Expand All @@ -48,11 +48,6 @@ holidays:
easter 49:
_name: easter 49
type: observance
07-25:
name:
es: Santiago Apostol
type: observance
note: regional
08-15:
_name: 08-15
10-12:
Expand Down Expand Up @@ -110,6 +105,8 @@ holidays:
AR:
name: Aragón
days:
easter -3:
_name: easter -3
04-23:
name:
es: Día de Aragón
Expand All @@ -126,6 +123,8 @@ holidays:
AS:
name: Asturias
days:
easter -3:
_name: easter -3
substitutes 05-01 if Sunday then next Monday:
substitute: true
_name: 05-01
Expand All @@ -140,6 +139,8 @@ holidays:
CB:
name: Cantabria
days:
easter -3:
_name: easter -3
06-28:
name: Día de las Instituciones de Cantabria
substitutes 06-28 if Sunday then next Monday:
Expand All @@ -151,6 +152,8 @@ holidays:
CE:
name: Ciudad de Ceuta
days:
easter -3:
_name: easter -3
08-05:
name: Nuestra Señora de África
substitutes 08-05 if Sunday then next Monday:
Expand All @@ -168,6 +171,8 @@ holidays:
es: Castilla y León
en: Castile and León
days:
easter -3:
_name: easter -3
04-23:
name: Fiesta de Castilla y León
substitutes 04-23 if Sunday then next Monday:
Expand All @@ -182,6 +187,8 @@ holidays:
CM:
name: Castile-La Mancha
days:
easter -3:
_name: easter -3
05-31 since 2020:
name: Día de Castilla-La Mancha
substitutes 05-31 if Sunday then next Monday since 2020:
Expand Down Expand Up @@ -283,6 +290,8 @@ holidays:
EX:
name: Extremadura
days:
easter -3:
_name: easter -3
substitutes 05-01 if Sunday then next Monday:
substitute: true
_name: 05-01
Expand All @@ -294,6 +303,8 @@ holidays:
GA:
name: Galicia
days:
easter -3:
_name: easter -3
05-17:
name: Día de las Letras Gallegas
substitutes 05-17 if Sunday then next Monday:
Expand All @@ -316,6 +327,8 @@ holidays:
substitute: true
name:
es: Día de les Illes Balears
easter -3:
_name: easter -3
easter 1:
_name: easter 1
12-26:
Expand All @@ -325,12 +338,16 @@ holidays:
MC:
name: Murcia Region
days:
easter -3:
_name: easter -3
substitutes 05-01 if Sunday then next Monday:
substitute: true
_name: 05-01
MD:
name: Comunidad de Madrid
days:
easter -3:
_name: easter -3
05-02 if Sunday then next Monday:
name:
es: Día de la Comunidad de Madrid
Expand All @@ -342,18 +359,15 @@ holidays:
name:
es: San Isidro Labrador
type: observance
07-25:
name: Santiago Apóstol
substitutes 07-25 if Sunday then next Monday:
substitute: true
name: Santiago Apóstol
11-09 if sunday then next monday:
name:
es: Nuestra Señora de la Almudena
type: observance
ML:
name: Ciudad de Melilla
days:
easter -3:
_name: easter -3
1 Shawwal:
_name: 1 Shawwal
10 Dhu al-Hijjah:
Expand All @@ -363,18 +377,19 @@ holidays:
es: Comunidad Foral de Navarra
en: Navarra Chartered Community
days:
easter -3:
_name: easter -3
easter 1:
_name: easter 1
07-25:
name: Santiago Apóstol
substitutes 07-25 if Sunday then next Monday:
substitute: true
name: Santiago Apóstol
# Lunes siguiente al Día de la Constitución Española is not observed
substitutes 12-06 if sunday then next monday: false
PV:
names:
es: País Vasco
en: Basque Country
days:
easter -3:
_name: easter -3
easter 1:
_name: easter 1
07-25:
Expand All @@ -387,6 +402,8 @@ holidays:
RI:
name: La Rioja
days:
easter -3:
_name: easter -3
easter 1:
_name: easter 1
VC:
Expand Down
2 changes: 2 additions & 0 deletions data/countries/IC.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ holidays:
dayoff: sunday
_days: ES
days:
easter -3:
_name: easter -3
05-30:
name:
es: Día de Canarias
Expand Down
19 changes: 0 additions & 19 deletions test/fixtures/ES-2015.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,6 @@
"rule": "03-19",
"_weekday": "Thu"
},
{
"date": "2015-04-02 00:00:00",
"start": "2015-04-01T22:00:00.000Z",
"end": "2015-04-02T22:00:00.000Z",
"name": "Jueves Santo",
"type": "public",
"rule": "easter -3",
"_weekday": "Thu"
},
{
"date": "2015-04-03 00:00:00",
"start": "2015-04-02T22:00:00.000Z",
Expand Down Expand Up @@ -80,16 +71,6 @@
"rule": "easter 49",
"_weekday": "Sun"
},
{
"date": "2015-07-25 00:00:00",
"start": "2015-07-24T22:00:00.000Z",
"end": "2015-07-25T22:00:00.000Z",
"name": "Santiago Apostol",
"type": "observance",
"note": "regional",
"rule": "07-25",
"_weekday": "Sat"
},
{
"date": "2015-08-15 00:00:00",
"start": "2015-08-14T22:00:00.000Z",
Expand Down
19 changes: 0 additions & 19 deletions test/fixtures/ES-2016.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,6 @@
"rule": "03-19",
"_weekday": "Sat"
},
{
"date": "2016-03-24 00:00:00",
"start": "2016-03-23T23:00:00.000Z",
"end": "2016-03-24T23:00:00.000Z",
"name": "Jueves Santo",
"type": "public",
"rule": "easter -3",
"_weekday": "Thu"
},
{
"date": "2016-03-25 00:00:00",
"start": "2016-03-24T23:00:00.000Z",
Expand Down Expand Up @@ -80,16 +71,6 @@
"rule": "easter 49",
"_weekday": "Sun"
},
{
"date": "2016-07-25 00:00:00",
"start": "2016-07-24T22:00:00.000Z",
"end": "2016-07-25T22:00:00.000Z",
"name": "Santiago Apostol",
"type": "observance",
"note": "regional",
"rule": "07-25",
"_weekday": "Mon"
},
{
"date": "2016-08-15 00:00:00",
"start": "2016-08-14T22:00:00.000Z",
Expand Down
19 changes: 0 additions & 19 deletions test/fixtures/ES-2017.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,6 @@
"rule": "03-19",
"_weekday": "Sun"
},
{
"date": "2017-04-13 00:00:00",
"start": "2017-04-12T22:00:00.000Z",
"end": "2017-04-13T22:00:00.000Z",
"name": "Jueves Santo",
"type": "public",
"rule": "easter -3",
"_weekday": "Thu"
},
{
"date": "2017-04-14 00:00:00",
"start": "2017-04-13T22:00:00.000Z",
Expand Down Expand Up @@ -90,16 +81,6 @@
"rule": "easter 49",
"_weekday": "Sun"
},
{
"date": "2017-07-25 00:00:00",
"start": "2017-07-24T22:00:00.000Z",
"end": "2017-07-25T22:00:00.000Z",
"name": "Santiago Apostol",
"type": "observance",
"note": "regional",
"rule": "07-25",
"_weekday": "Tue"
},
{
"date": "2017-08-15 00:00:00",
"start": "2017-08-14T22:00:00.000Z",
Expand Down
19 changes: 0 additions & 19 deletions test/fixtures/ES-2018.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,6 @@
"rule": "03-19",
"_weekday": "Mon"
},
{
"date": "2018-03-29 00:00:00",
"start": "2018-03-28T22:00:00.000Z",
"end": "2018-03-29T22:00:00.000Z",
"name": "Jueves Santo",
"type": "public",
"rule": "easter -3",
"_weekday": "Thu"
},
{
"date": "2018-03-30 00:00:00",
"start": "2018-03-29T22:00:00.000Z",
Expand Down Expand Up @@ -80,16 +71,6 @@
"rule": "easter 49",
"_weekday": "Sun"
},
{
"date": "2018-07-25 00:00:00",
"start": "2018-07-24T22:00:00.000Z",
"end": "2018-07-25T22:00:00.000Z",
"name": "Santiago Apostol",
"type": "observance",
"note": "regional",
"rule": "07-25",
"_weekday": "Wed"
},
{
"date": "2018-08-15 00:00:00",
"start": "2018-08-14T22:00:00.000Z",
Expand Down
19 changes: 0 additions & 19 deletions test/fixtures/ES-2019.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,6 @@
"rule": "03-19",
"_weekday": "Tue"
},
{
"date": "2019-04-18 00:00:00",
"start": "2019-04-17T22:00:00.000Z",
"end": "2019-04-18T22:00:00.000Z",
"name": "Jueves Santo",
"type": "public",
"rule": "easter -3",
"_weekday": "Thu"
},
{
"date": "2019-04-19 00:00:00",
"start": "2019-04-18T22:00:00.000Z",
Expand Down Expand Up @@ -90,16 +81,6 @@
"rule": "easter 49",
"_weekday": "Sun"
},
{
"date": "2019-07-25 00:00:00",
"start": "2019-07-24T22:00:00.000Z",
"end": "2019-07-25T22:00:00.000Z",
"name": "Santiago Apostol",
"type": "observance",
"note": "regional",
"rule": "07-25",
"_weekday": "Thu"
},
{
"date": "2019-08-15 00:00:00",
"start": "2019-08-14T22:00:00.000Z",
Expand Down
19 changes: 0 additions & 19 deletions test/fixtures/ES-2020.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,6 @@
"rule": "03-19",
"_weekday": "Thu"
},
{
"date": "2020-04-09 00:00:00",
"start": "2020-04-08T22:00:00.000Z",
"end": "2020-04-09T22:00:00.000Z",
"name": "Jueves Santo",
"type": "public",
"rule": "easter -3",
"_weekday": "Thu"
},
{
"date": "2020-04-10 00:00:00",
"start": "2020-04-09T22:00:00.000Z",
Expand Down Expand Up @@ -80,16 +71,6 @@
"rule": "easter 49",
"_weekday": "Sun"
},
{
"date": "2020-07-25 00:00:00",
"start": "2020-07-24T22:00:00.000Z",
"end": "2020-07-25T22:00:00.000Z",
"name": "Santiago Apostol",
"type": "observance",
"note": "regional",
"rule": "07-25",
"_weekday": "Sat"
},
{
"date": "2020-08-15 00:00:00",
"start": "2020-08-14T22:00:00.000Z",
Expand Down
Loading
Loading