Skip to content

fix(NC,RE,GP,WF,PF): Fix FR territory bugs and add missing overseas collectivities#586

Merged
commenthol merged 1 commit intocommenthol:masterfrom
kevinley:fix/fr-holidays-report-issues
Mar 28, 2026
Merged

fix(NC,RE,GP,WF,PF): Fix FR territory bugs and add missing overseas collectivities#586
commenthol merged 1 commit intocommenthol:masterfrom
kevinley:fix/fr-holidays-report-issues

Conversation

@kevinley
Copy link
Copy Markdown
Contributor

@kevinley kevinley commented Mar 25, 2026

What this PR does

This PR fixes several bugs in French overseas territory holiday definitions and adds two missing territories (Wallis-et-Futuna and French Polynesia).

Bug fixes

  • New Caledonia (NC): Fixed a typo in the holiday name "Fête de la Citoyenneté" (was misspelled as "Citonneyeté")
  • Réunion (RE): Corrected the source comment URL, which mistakenly pointed to Mayotte instead of Réunion
  • Guadeloupe (GP): Switched to the canonical America/Guadeloupe timezone instead of America/Port_of_Spain (both are UTC-4, but Guadeloupe is the proper IANA zone for the territory)

New territories

  • Wallis-et-Futuna (WF): Added with 3 local public holidays:

    • Saint Pierre-Chanel Day (April 28)
    • Saints Peter and Paul Day (June 29)
    • Territory Day (July 29)
  • French Polynesia (PF): Added with 3 local public holidays:

    • Missionary Day (March 5)
    • Good Friday
    • Autonomy Day (June 29, through 2025), replaced by Matari'i (November 20, starting 2026 per Loi du pays n°2025-12)

How it was tested

  • YAML builds successfully
  • Test fixtures regenerated for NC, RE, GP, WF, PF, and FR (state-level)
  • Full test suite passes (5220 tests + TypeScript type checks)
  • All holiday dates and names verified against official government sources and the IANA timezone database

…ollectivities

- fix(NC): Correct typo in Fête de la Citoyenneté holiday name
- fix(RE): Fix source comment URL to reference Reunion instead of Mayotte
- fix(GP): Use canonical America/Guadeloupe timezone instead of America/Port_of_Spain
- feat(WF): Add Wallis-et-Futuna with Saint Pierre-Chanel, Saints Peter and Paul, and Territory Day
- feat(PF): Add French Polynesia with Missionary Day, Good Friday, Autonomy Day (until 2025), and Matari'i (from 2026)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@commenthol commenthol merged commit 376a80a into commenthol:master Mar 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants