Skip to content

More Proto4 changes#468

Merged
indigodarkwolf merged 3 commits into
commanderx16:masterfrom
akumanatt:proto4
Feb 4, 2023
Merged

More Proto4 changes#468
indigodarkwolf merged 3 commits into
commanderx16:masterfrom
akumanatt:proto4

Conversation

@akumanatt

Copy link
Copy Markdown
Contributor

No description provided.

@indigodarkwolf

Copy link
Copy Markdown
Collaborator

I can't recall where, but I know we had a conversation with folks about whether this was the correct approach to clock stretching, and given how the CPU is currently simulated, this seems correct. I'm not sure if this will be a hazard for @ziplantil and pull request #437, but I'm going to go ahead and accept this PR anyways because it represents known hardware changes.

@ziplantil, I apologize if it seems like your PR has been left to stew; that was not my intention, and I'm sure it wasn't Michael's intention, either. I am sure I didn't get a notification from Github when it was flipped over to "ready", and by the time I noticed, there was a bunch of other stuff submitted that I knew was being anticipated by folks in the wider community.

@indigodarkwolf indigodarkwolf merged commit be2005b into commanderx16:master Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants