More Proto4 changes#468
Merged
Merged
Conversation
Collaborator
|
I can't recall where, but I know we had a conversation with folks about whether this was the correct approach to clock stretching, and given how the CPU is currently simulated, this seems correct. I'm not sure if this will be a hazard for @ziplantil and pull request #437, but I'm going to go ahead and accept this PR anyways because it represents known hardware changes. @ziplantil, I apologize if it seems like your PR has been left to stew; that was not my intention, and I'm sure it wasn't Michael's intention, either. I am sure I didn't get a notification from Github when it was flipped over to "ready", and by the time I noticed, there was a bunch of other stuff submitted that I knew was being anticipated by folks in the wider community. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.